Implemented rebuild cmd for history snapshots #17961
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eastorski
requested review from
AskAlexSharov,
Giulio2002 and
sudeepdino008
as code owners
AskAlexSharov
requested changes
Nov 19, 2025
db/state/history.go
Outdated
| return nil | ||
| } | ||
|
|
||
| func (ht *HistoryRoTx) Rebuild(ctx context.Context, fromTxNum, toTxNum uint64) error { |
Collaborator
There was a problem hiding this comment.
Rebuild method doesn't have comment - so i'm not sure what this method intended to do. I see it calling merge - if it's just a merge then why it's not called Merge?
| } | ||
|
|
||
| var rebuildCmd = &cobra.Command{ | ||
| Use: "rebuild", |
Collaborator
There was a problem hiding this comment.
no description of cli method - in erigon snapshots --help will be impossible to understand what rebuild sub-command does - because it's generic name.
eastorski
force-pushed
the
eastorski/snapshot-rebuild-tool
branch
from
8d9c20c to
b001856
Compare
Member
Author
|
I am closing the pr because the changes will be added to this PR #17958 since it becomes more related to each other after the discussion in the comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.